Adding more instances is messing up my volume attachments

romuloslv · September 21, 2023, 1:51am

Hey guys, ok? I’m facing problems with disk attacks when adding/removing new instances. Can anyone help?

github.com/hashicorp/terraform-provider-aws

ALL aws_volume_attachment getting recreated when adding new EBS disk

opened 11:20PM - 02 Oct 19 UTC

service/ec2

_This issue was originally opened by @vmorkunas as hashicorp/terraform#22975. It… was migrated here as a result of the [provider split](https://www.hashicorp.com/blog/upcoming-provider-changes-in-terraform-0-10/). The original body of the issue is below._ <hr> Hello, I have a code which works fine on all cases except when new EBS disk is added to the list. On second apply it destroys all EBS attachments which were created in same module and creates them again. ``` resource "aws_ebs_volume" "default" { for_each = { # key is name_tag, value is list of strings for s in local.ebs_block_devices: format("%s-%s",element(split(local.delim, s),local.name_tag_index),element(split(local.delim, s),local.device_name)) => split(local.delim, s)} availability_zone = "${element(each.value,local.az_index)}" size = "${element(each.value,local.volume_size_index)}" type = "${element(each.value,local.volume_type_index)}" tags = "${merge( map( "Name", "${format("%s-%s",local.stackAndClusterName,format("%s-%s",element(each.value,local.name_tag_index),element(each.value,local.device_name)))}"), "${var.clusterCommon.common_tags}" )}" } resource "aws_volume_attachment" "default" { for_each = { # key is name_tag, value is list of strings for s in local.ebs_block_devices: format("%s-%s",element(split(local.delim, s),local.name_tag_index),element(split(local.delim, s),local.device_name)) => split(local.delim, s) } device_name = "${element(each.value,local.device_name)}" volume_id = "${lookup(aws_ebs_volume.default, each.key).id}" instance_id = "${lookup(aws_instance.ec2, element(split("-/", each.key), local.name_tag_index)).id}" } ``` Plan output ``` # module.EC2.aws_volume_attachment.default["B1./dev/sdf"] must be replaced -/+ resource "aws_volume_attachment" "default" { device_name = "/dev/sdf" ~ id = "vai-3606475186" -> (known after apply) instance_id = "i-09a547764c468f3fb" ~ volume_id = "vol-0c9a0a822870ab11d" -> (known after apply) # forces replacement } ``` ### Terraform Version 0.12.9 ### Expected Behavior New EBS disk is added and attached to the EC2 instance. ### Actual Behavior Disk is added but all attachments created in the same module are recreated. ### Steps to Reproduce 1. Creating multiple EC2, EBS, EBS attachments in the same module. 2. Add one more EBS disk to EC2 3. Terraform apply again

Topic		Replies	Views
Attachment order in aws_volume_attachment AWS	7	4496	May 18, 2020
EBS Volume attachments are being reassigned AWS	6	362	June 22, 2023
ALL aws_volume_attachment getting recreated when adding new EBS disk to the list Terraform	0	437	October 2, 2019
Dynamic attach secondary volume if needed Terraform	2	1577	June 4, 2020
For_each on a count resource and unknown keys: alternatives vs -target? Terraform	2	749	October 24, 2023

Adding more instances is messing up my volume attachments

Related topics