Invalid function argument after 0.12 upgrade

@apparentlymart Thank for your response.

I actually have 2 issues that are very similar to each other.

so the first error is

Error: Provider produced inconsistent result after apply
When applying changes to
module.registry_docker.module.docker_install.null_resource.docker_installer_configurer,
provider "registry.terraform.io/-/null" produced an unexpected new value for
.id: was null, but now cty.StringVal("992243335272418932").
This is a bug in the provider, which should be reported in the provider's own
issue tracker.

so I checked the state file and got this

287        "name": "docker_installer_configurer",
   288        "provider": "provider.null",
   289        "instances": [
   290          {
   291            "status": "tainted",
   292            "schema_version": 0,
   293            "attributes": {
   294              "id": "992243335272418932",
   295              "triggers": null
   296            },

The second error is the same as my initial post

Error: Invalid function argument

  on tf-modules/common/docker/install/output.tf line 2, in output "id":
   2:   value = "${join(",",null_resource.docker_installer[*].id)}"
    |----------------
    | null_resource.docker_installer is tuple with 1 element

Invalid value for "lists" parameter: element 0 is null; cannot concatenate
null values.

I checked the statefile and found

       "module": "module.registry_docker.module.docker_install",
  "mode": "managed",
  "type": "null_resource",
  "name": "docker_installer_configurer",
  "provider": "provider.null",
  "instances": [
    {
      "status": "tainted",
      "schema_version": 0,
      "attributes": {
        "id": "992243335272418932",
        "triggers": null
      },
      "private": "bnVsbA==",
      "dependencies": [
        "module.registry_docker.module.docker_install.null_resource.docker_installer",
        "module.registry_docker.module.docker_install.null_resource.docker_installer_configure_external_registry",
        "module.registry_docker.module.docker_install.null_resource.docker_installer_configure_inner_registry"
      ]
    }
  ]
},

and

{
  "module": "module.registry_docker.module.docker_install",
  "mode": "managed",
  "type": "null_resource",
  "name": "docker_installer",
  "each": "list",
  "provider": "provider.null",
  "instances": []
},

so for this second block of code its pretty clear that there is no “id” field but I can’t seem to figure out what is going on here still