Thanks @ohmer!!
Totally forgot about that ...
operator. I just changed your line a bit to make it a bit shorter:
vpce_associations = concat([
for idx, key in local.vpc_vpce_ids :
setproduct(key, local.default_snet_ids[idx])
]...)
All good now. ty!!
-S