Is there a way to import the `aws_autoscaling_attachment` resource?

marcelomanchester · August 8, 2024, 1:33pm

I’m working on moving some existing infrastructure into a new remote state and tf repository and would need to import an aws_autoscaling_attachment resource for tracking my eks-managed node group attachment to a NLB target group, but looking at the docs I couldn’t find the import instructions at the bottom of the screen.

So is there a way to import it?

jar-b · August 8, 2024, 3:37pm

You are correct, the aws_autoscaling_attachment resource does not currently support import. Browsing the code ,I don’t see anything obvious that would prevent adding import support, so a feature request is probably the best way to describe the use case and start collecting community support for prioritization.

marcelomanchester · August 8, 2024, 6:53pm

Got it! Thanks for the quick reply.

I’m planning to try it myself, found this link which looks like a good guide to get started.

Do you know any other docs that can help me? it will be my first contribution to the project

jar-b · August 14, 2024, 1:53pm

The contributor guide is a great place to start, especially for instructions on setting up the project and development environment.

Beyond that you can look to other SDKv2 based resource which support import as examples. For this case, another “attachment-like” resource such as aws_iam_role_policy_attachment would be a good candidate:

github.com

hashicorp/terraform-provider-aws/blob/031174d39e169b9a97cbc6b8dfe0ead0fe0b3680/internal/service/iam/role_policy_attachment.go#L109-L123


      
          func resourceRolePolicyAttachmentImport(ctx context.Context, d *schema.ResourceData, meta interface{}) ([]*schema.ResourceData, error) {
          	idParts := strings.SplitN(d.Id(), "/", 2)
          	if len(idParts) != 2 || idParts[0] == "" || idParts[1] == "" {
          		return nil, fmt.Errorf("unexpected format of ID (%q), expected <role-name>/<policy_arn>", d.Id())
          	}
          
          	roleName := idParts[0]
          	policyARN := idParts[1]
          
          	d.Set(names.AttrRole, roleName)
          	d.Set("policy_arn", policyARN)
          	d.SetId(fmt.Sprintf("%s-%s", roleName, policyARN))
          
          	return []*schema.ResourceData{d}, nil
          }

The only note I’d make about this example is that we prefer comma-delimited multi-part IDs whenever possible. This resource has been around for a long time and uses a non-preferred delimiter (/) which, while not ideal, we don’t intend to make a breaking change to address.

Hope this helps!